jenkins-bot has submitted this change and it was merged.
Change subject: mw.ViewPageTarget: Use native .focus() rather than jQuery's
.focus()
......................................................................
mw.ViewPageTarget: Use native .focus() rather than jQuery's .focus()
jQuery's implementation does some sort of traversal, so on large pages
it took 300-400ms just to focus the document node.
Change-Id: I0de95d8800a1aedeb19b27d204dfd8fd08cec533
---
M modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
index 2255695..ec4b100 100644
--- a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
@@ -354,7 +354,7 @@
this.restoreScrollPosition();
this.restoreEditSection();
this.setupBeforeUnloadHandler();
- this.$document.focus();
+ this.$document[0].focus();
this.activating = false;
}
};
@@ -634,7 +634,7 @@
ve.init.mw.ViewPageTarget.prototype.onToolbarEditNoticesToolClick = function
() {
this.$toolbarEditNotices.fadeToggle( 'fast' );
this.$toolbarBetaNotice.fadeOut( 'fast' );
- this.$document.focus();
+ this.$document[0].focus();
};
/**
@@ -646,7 +646,7 @@
ve.init.mw.ViewPageTarget.prototype.onToolbarBetaNoticeToolClick = function ()
{
this.$toolbarBetaNotice.fadeToggle( 'fast' );
this.$toolbarEditNotices.fadeOut( 'fast' );
- this.$document.focus();
+ this.$document[0].focus();
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/69760
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0de95d8800a1aedeb19b27d204dfd8fd08cec533
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
