jenkins-bot has submitted this change and it was merged.
Change subject: Fix crasher in cleanupLIHack when dsr is absent (ex: tpl
content)
......................................................................
Fix crasher in cleanupLIHack when dsr is absent (ex: tpl content)
* Fixes crasher of en/INNA:_Live_la_Arenele_Romane
* No change in parser tests
Change-Id: Id6fb1c30ca561da2cc06852c318745069ac29985
---
M js/lib/mediawiki.DOMPostProcessor.js
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
GWicke: Looks good to me, approved
jenkins-bot: Verified
diff --git a/js/lib/mediawiki.DOMPostProcessor.js
b/js/lib/mediawiki.DOMPostProcessor.js
index f3ada3e..2497fe4 100644
--- a/js/lib/mediawiki.DOMPostProcessor.js
+++ b/js/lib/mediawiki.DOMPostProcessor.js
@@ -2498,10 +2498,12 @@
var nodeDSR = node.data.parsoid.dsr,
prevNodeDSR = prevNode.data.parsoid.dsr;
- node.data.parsoid.dsr = [ prevNodeDSR[0],
- nodeDSR[1],
- nodeDSR[2] + prevNodeDSR[1] -
prevNodeDSR[0],
- nodeDSR[3] ];
+ if (nodeDSR && prevNodeDSR) {
+ node.data.parsoid.dsr = [ prevNodeDSR[0],
+ nodeDSR[1],
+ nodeDSR[2] + prevNodeDSR[1] -
prevNodeDSR[0],
+ nodeDSR[3] ];
+ }
// Delete the duplicated <li> node.
deleteNode(prevNode);
--
To view, visit https://gerrit.wikimedia.org/r/69956
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id6fb1c30ca561da2cc06852c318745069ac29985
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: GWicke <[email protected]>
Gerrit-Reviewer: Rsmith <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
