Catrope has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/70119


Change subject: Fix empty inspector popout bug in Firefox
......................................................................

Fix empty inspector popout bug in Firefox

Due to some sort of mysterious race condition (probably deferred reflow)
calling this.$menu.show() set style="" rather than style="display:block;"
because Firefox believed the parent was still hidden.

Work around this by removing display:none; from the context's CSS rules.
We don't need it because we always manually .hide() these things anyway.

Bug: 50073
Change-Id: I29e210aba9a6265d8364ff8ae49408cb4c2428b9
---
M modules/ve/ui/styles/ve.ui.Context.css
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/19/70119/1

diff --git a/modules/ve/ui/styles/ve.ui.Context.css 
b/modules/ve/ui/styles/ve.ui.Context.css
index 552e3c2..93a2ab7 100644
--- a/modules/ve/ui/styles/ve.ui.Context.css
+++ b/modules/ve/ui/styles/ve.ui.Context.css
@@ -9,7 +9,6 @@
 .ve-ui-context-inspectors,
 .ve-ui-context-menu {
        position: absolute;
-       display: none;
 }
 
 .ve-ui-context-menu .ve-ui-toolbar-bar {

-- 
To view, visit https://gerrit.wikimedia.org/r/70119
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I29e210aba9a6265d8364ff8ae49408cb4c2428b9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to