Tobias Gritschacher has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/70141


Change subject: Fixed Special:SetSiteLink
......................................................................

Fixed Special:SetSiteLink

* this got broken in I200a005bf2eb5d38b328ddd6bcb59978976422b4

Change-Id: I3bd5328caaec023991e5940b094e63910ecb2867
---
M repo/includes/specials/SpecialSetSiteLink.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/41/70141/1

diff --git a/repo/includes/specials/SpecialSetSiteLink.php 
b/repo/includes/specials/SpecialSetSiteLink.php
index 9cc51ed..060635e 100644
--- a/repo/includes/specials/SpecialSetSiteLink.php
+++ b/repo/includes/specials/SpecialSetSiteLink.php
@@ -256,6 +256,7 @@
                $site = \Sites::singleton()->getSite( $siteId );
                $status = \Status::newGood();
 
+               #var_dump($site);
                if ( $site === null ) {
                        $status->error( 'wikibase-setsitelink-invalid-site', 
$siteId );
                        return $status;
@@ -263,7 +264,6 @@
 
                if ( $pageName !== '' ) {
                        // Don't try to normalize an empty string (which means: 
remove the link)
-                       $page = $site->normalizePageName( $page );
                        $pageName = $site->normalizePageName( $pageName );
 
                        if ( $pageName === false ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/70141
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3bd5328caaec023991e5940b094e63910ecb2867
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to