Henning Snater has uploaded a new change for review.
https://gerrit.wikimedia.org/r/70147
Change subject: Fixes jslint and doxygen errors introduced in Ie12d526 and
I57a6ad9
......................................................................
Fixes jslint and doxygen errors introduced in Ie12d526 and I57a6ad9
Change-Id: I3e597bc89360f7e491cfdc258509be287490d2d3
---
M ValueView/resources/jquery.ui/jquery.ui.listrotator.js
M
ValueView/resources/jquery.valueview/valueview.experts/experts.GlobeCoordinateInput.js
M
ValueView/tests/qunit/jquery.valueview/valueview.experts/experts.GlobeCoordinateInput.tests.js
3 files changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataValues
refs/changes/47/70147/1
diff --git a/ValueView/resources/jquery.ui/jquery.ui.listrotator.js
b/ValueView/resources/jquery.ui/jquery.ui.listrotator.js
index f266999..dc37c23 100644
--- a/ValueView/resources/jquery.ui/jquery.ui.listrotator.js
+++ b/ValueView/resources/jquery.ui/jquery.ui.listrotator.js
@@ -558,7 +558,7 @@
* Returns whether the listrotator is currently set to "auto",
meaning that the value
* returned by value() has not been chosen by the user
explicitly.
*
- * @returns boolean
+ * @return {boolean}
*/
autoActive: function() {
return this.$auto.hasClass( 'ui-state-active' );
diff --git
a/ValueView/resources/jquery.valueview/valueview.experts/experts.GlobeCoordinateInput.js
b/ValueView/resources/jquery.valueview/valueview.experts/experts.GlobeCoordinateInput.js
index ea01516..ce41f16 100644
---
a/ValueView/resources/jquery.valueview/valueview.experts/experts.GlobeCoordinateInput.js
+++
b/ValueView/resources/jquery.valueview/valueview.experts/experts.GlobeCoordinateInput.js
@@ -35,7 +35,7 @@
* the new value has been called. The use of this, basically,
is a structural improvement
* which allows moving setting the displayed value to the
draw() method which is supposed to
* handle all visual manners.
- * @type {string|null|false}
+ * @type {string|null|false}
*/
_newValue: null,
@@ -171,7 +171,6 @@
var options = {},
precisionWidget = this.$precision.data(
'listrotator' );
- // TODO: Don't access the widget's internals here,
check this via some function.
if( !precisionWidget.autoActive() ) {
var precision = getPrecisionSetting(
precisionWidget.value() );
diff --git
a/ValueView/tests/qunit/jquery.valueview/valueview.experts/experts.GlobeCoordinateInput.tests.js
b/ValueView/tests/qunit/jquery.valueview/valueview.experts/experts.GlobeCoordinateInput.tests.js
index 8dd81bf..3555371 100644
---
a/ValueView/tests/qunit/jquery.valueview/valueview.experts/experts.GlobeCoordinateInput.tests.js
+++
b/ValueView/tests/qunit/jquery.valueview/valueview.experts/experts.GlobeCoordinateInput.tests.js
@@ -21,7 +21,7 @@
'foo' // Might not be a valid coordinate, but
that's for the parser to decide, the expert shouldn't care.
],
unknown:
testExpert.basicTestDefinition.rawValues.unknown.concat( [
- 42,
+ 42
] )
},
relatedValueParser: GlobeCoordinateParser
--
To view, visit https://gerrit.wikimedia.org/r/70147
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e597bc89360f7e491cfdc258509be287490d2d3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
