Tobias Gritschacher has uploaded a new change for review.
https://gerrit.wikimedia.org/r/70150
Change subject: Improvements to Selenium coordinate tests
......................................................................
Improvements to Selenium coordinate tests
Change-Id: I2bf4db2f44efe91001aec47499421715ec69205c
---
M repo/tests/selenium/statements/statements_coordinate_spec.rb
M selenium/lib/modules/coordinate_module.rb
2 files changed, 10 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/50/70150/1
diff --git a/repo/tests/selenium/statements/statements_coordinate_spec.rb
b/repo/tests/selenium/statements/statements_coordinate_spec.rb
index bef2b27..73b44a1 100644
--- a/repo/tests/selenium/statements/statements_coordinate_spec.rb
+++ b/repo/tests/selenium/statements/statements_coordinate_spec.rb
@@ -41,11 +41,12 @@
"expected_preview" => "42°9'13.7\"N, 8°34'23.2\"E"
})
coordinate_values.push({
- "input" => "42° 09.231' N, 008° 34.386' E",
+ "input" => "42° 09.231' N 008° 34.386' E",
"precision" => "auto",
"expected_precision" => "to 1/100 of an arcsecond",
"expected_preview" => "42°9'13.86\"N, 8°34'23.16\"E"
})
+
coordinate_values.push({
"input" => "stuff",
"precision" => "auto",
@@ -116,9 +117,11 @@
page.statementValueInputField_element.clear
page.statementValueInputField = coordinate["input"]
page.inputExtender_element.when_visible
- page.previewSpinner_element.when_not_visible
+ page.previewSpinner_element.when_not_visible(10)
+ ajax_wait
page.select_coordinate_precision coordinate["precision"]
- page.previewSpinner_element.when_not_visible
+ page.previewSpinner_element.when_not_visible(10)
+ ajax_wait
page.inputPreviewValue.should == coordinate["expected_preview"]
page.coordinatePrecisionRotatorSelect_element.text.should ==
coordinate["expected_precision"]
page.cancelStatement
@@ -136,7 +139,8 @@
page.wait_for_entity_selector_list
page.wait_for_property_value_box
page.statementValueInputField = coordinate_values[0]["input"]
- page.previewSpinner_element.when_not_visible
+ page.previewSpinner_element.when_not_visible(10)
+ ajax_wait
page.saveStatement?.should be_true
page.saveStatement
ajax_wait
diff --git a/selenium/lib/modules/coordinate_module.rb
b/selenium/lib/modules/coordinate_module.rb
index fae2fe3..4ab7c33 100644
--- a/selenium/lib/modules/coordinate_module.rb
+++ b/selenium/lib/modules/coordinate_module.rb
@@ -24,7 +24,7 @@
return
end
self.coordinatePrecisionRotatorSelect
- self.coordinatePrecisionMenu_element.when_visible
+ self.coordinatePrecisionMenu_element.when_visible(10)
self.coordinatePrecisionMenu_element.each do |item|
if item.text == prec
item.click
@@ -36,7 +36,7 @@
def show_advanced_coordinate_settings
if !self.coordinatePrecision_element.visible?
self.coordinateInputExtenderAdvanced
- self.coordinatePrecision_element.when_visible
+ self.coordinatePrecision_element.when_visible(10)
end
end
end
--
To view, visit https://gerrit.wikimedia.org/r/70150
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2bf4db2f44efe91001aec47499421715ec69205c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
