Milimetric has uploaded a new change for review.
https://gerrit.wikimedia.org/r/70211
Change subject: fixed metrics test to fail
......................................................................
fixed metrics test to fail
Change-Id: I99cd4b3c78a70068738bf3f41ea0c865b1942cd6
---
M tests/test_controllers/test_metrics.py
1 file changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/analytics/wikimetrics
refs/changes/11/70211/1
diff --git a/tests/test_controllers/test_metrics.py
b/tests/test_controllers/test_metrics.py
index 1e584b3..9642f11 100644
--- a/tests/test_controllers/test_metrics.py
+++ b/tests/test_controllers/test_metrics.py
@@ -6,7 +6,13 @@
def test_index(self):
response = self.app.get('/metrics/', follow_redirects=True)
- assert_true(
- response._status_code == 200,
+ assert_equal(
+ response.status_code,
+ 200,
+ '/metrics should return OK'
+ )
+ assert_equal(
+ response.data.find('log in with Google'),
+ -1,
'/metrics should get the list of metrics'
)
--
To view, visit https://gerrit.wikimedia.org/r/70211
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I99cd4b3c78a70068738bf3f41ea0c865b1942cd6
Gerrit-PatchSet: 1
Gerrit-Project: analytics/wikimetrics
Gerrit-Branch: master
Gerrit-Owner: Milimetric <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
