Reedy has uploaded a new change for review.
https://gerrit.wikimedia.org/r/70226
Change subject: ProofreadPage Fatal error: Call to a member function exists()
on a non-object
......................................................................
ProofreadPage Fatal error: Call to a member function exists() on a non-object
wfFindFile() can return false; not documented to return null
Bug: 50117
Change-Id: I5146e4425a25babb0190ee9d8769a20ef80b35ed
---
M ProofreadPage.body.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage
refs/changes/26/70226/1
diff --git a/ProofreadPage.body.php b/ProofreadPage.body.php
index 0d2ed5d..215d2a1 100644
--- a/ProofreadPage.body.php
+++ b/ProofreadPage.body.php
@@ -157,7 +157,7 @@
}
$image = wfFindFile( $imageTitle );
// if it is multipage, we use the page order of the file
- if ( $image !== null && $image->exists() &&
$image->isMultipage() ) {
+ if ( $image && $image->exists() && $image->isMultipage() ) {
$indexTitle = Title::makeTitle(
self::getIndexNamespaceId(), $image->getTitle()->getText() );
if ( $indexTitle !== null ) {
$title->prpIndexPage =
ProofreadIndexPage::newFromTitle( $indexTitle );
--
To view, visit https://gerrit.wikimedia.org/r/70226
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5146e4425a25babb0190ee9d8769a20ef80b35ed
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Reedy <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
