Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/70229
Change subject: Scroll to correct offset after using a section edit link
......................................................................
Scroll to correct offset after using a section edit link
Needs to wait 200ms so it account for toolbar height.
Bug: 49563
Change-Id: I3a57e64f54289a3263814b4fbfe00c63de4a490b
---
M modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/29/70229/1
diff --git a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
index 43d9862..b964602 100644
--- a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
@@ -1877,15 +1877,23 @@
ve.init.mw.ViewPageTarget.prototype.restoreEditSection = function () {
if ( this.section !== null ) {
var offset,
+ target = this,
surfaceView = this.surface.getView(),
surfaceModel = surfaceView.getModel();
this.$document.find( 'h1, h2, h3, h4, h5, h6' ).eq(
this.section - 1 ).each( function () {
var headingNode = $( this ).data( 'view' );
+
if ( headingNode ) {
offset =
surfaceModel.getDocument().data.getNearestContentOffset(
headingNode.getModel().getOffset()
);
surfaceModel.change( null, new ve.Range(
offset, offset ) );
+ // Scroll to heading:
+ // Wait for toolbar to animate in so we can
account for its height
+ setTimeout( function () {
+ var $window = $(
ve.Element.static.getWindow( target.$ ) );
+ $window.scrollTop(
headingNode.$.offset().top - target.toolbar.$.height() );
+ }, 200 );
}
} );
this.section = null;
--
To view, visit https://gerrit.wikimedia.org/r/70229
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a57e64f54289a3263814b4fbfe00c63de4a490b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
