jenkins-bot has submitted this change and it was merged.
Change subject: Don't put slugs after internal nodes.
......................................................................
Don't put slugs after internal nodes.
Bug: 50132
Change-Id: I3818ebe9816e7d781233f087b15694bf7ba12965
---
M modules/ve/ce/ve.ce.BranchNode.js
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/ce/ve.ce.BranchNode.js
b/modules/ve/ce/ve.ce.BranchNode.js
index c6d6050..5e4959e 100644
--- a/modules/ve/ce/ve.ce.BranchNode.js
+++ b/modules/ve/ce/ve.ce.BranchNode.js
@@ -233,6 +233,10 @@
} else {
// Iterate over all children of this branch and add slugs in
appropriate places
for ( i = 0, len = this.children.length; i < len; i++ ) {
+ // Don't put slugs after internal nodes.
+ if ( ve.dm.nodeFactory.isNodeInternal(
this.children[i].model.type ) ) {
+ continue;
+ }
// First sluggable child (left side)
if ( i === 0 && this.children[i].canHaveSlugBefore() ) {
this.slugs[i] = doc.importNode( slug, true );
--
To view, visit https://gerrit.wikimedia.org/r/70333
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3818ebe9816e7d781233f087b15694bf7ba12965
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Robmoen <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
