jenkins-bot has submitted this change and it was merged.
Change subject: Prevent visual effect on disabled toolbar buttons
......................................................................
Prevent visual effect on disabled toolbar buttons
Bug: 33113
Change-Id: Icbf9ac6cff5e3f914268fe14d1b430609dedd49e
---
M modules/ve/ui/styles/ve.ui.Tool.css
1 file changed, 7 insertions(+), 7 deletions(-)
Approvals:
Trevor Parscal: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/ui/styles/ve.ui.Tool.css
b/modules/ve/ui/styles/ve.ui.Tool.css
index 394d7ba..63013c8 100644
--- a/modules/ve/ui/styles/ve.ui.Tool.css
+++ b/modules/ve/ui/styles/ve.ui.Tool.css
@@ -40,17 +40,17 @@
box-shadow: inset 0 0.07em 0.07em 0 rgba(0, 0, 0, 0.07);
}
-.ve-ui-widget-disabled.ve-ui-buttonTool:active {
+.ve-ui-buttonTool.ve-ui-widget-disabled:active {
background-image: none;
box-shadow: none;
}
-.ve-ui-widget-disabled.ve-ui-buttonTool {
- opacity: 0.25;
+.ve-ui-buttonTool.ve-ui-widget-disabled:hover {
+ border-color: transparent;
}
-.ve-ui-widget-disabled.ve-ui-buttonTool:hover {
- border-color: transparent;
+.ve-ui-buttonTool.ve-ui-widget-disabled {
+ cursor: auto;
}
.ve-ui-buttonTool-icon {
@@ -62,12 +62,12 @@
opacity: 0.8;
}
-.ve-ui-buttonTool:hover .ve-ui-buttonTool-icon {
+.ve-ui-buttonTool:not(.ve-ui-widget-disabled):hover .ve-ui-buttonTool-icon {
opacity: 1;
}
.ve-ui-widget-disabled .ve-ui-buttonTool-icon {
- opacity: 0.8;
+ opacity: 0.2;
}
/* ve.ui.DropdownTool */
--
To view, visit https://gerrit.wikimedia.org/r/70231
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icbf9ac6cff5e3f914268fe14d1b430609dedd49e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Robmoen <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Trevor Parscal <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
