Reedy has uploaded a new change for review.
https://gerrit.wikimedia.org/r/70648
Change subject: Don't upload if output looks erroneous
......................................................................
Don't upload if output looks erroneous
Not really ready for review
Change-Id: Ia6bb25636a1e64566bfe94d1d07570f90b0f2e85
---
M make-deploy-notes/uploadChangelog.php
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/release
refs/changes/48/70648/1
diff --git a/make-deploy-notes/uploadChangelog.php
b/make-deploy-notes/uploadChangelog.php
index 18fdb54..e4cb4c2 100644
--- a/make-deploy-notes/uploadChangelog.php
+++ b/make-deploy-notes/uploadChangelog.php
@@ -38,6 +38,11 @@
$output = shell_exec( "php -f ./make-deploy-notes {$escPrevVer} {$escVer}" );
+if ( strpos( $output, 'array(' ) !== false ) {
+ // Broken output, don't upload
+ return;
+}
+
require_once( 'botclasses.php' );
$wiki = new wikipedia( 'https://www.mediawiki.org/w/api.php' );
--
To view, visit https://gerrit.wikimedia.org/r/70648
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6bb25636a1e64566bfe94d1d07570f90b0f2e85
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/release
Gerrit-Branch: master
Gerrit-Owner: Reedy <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
