Yurik has submitted this change and it was merged.

Change subject: Revert "Constrain redirects to Wikipedia Zero partner-sourced 
requests."
......................................................................


Revert "Constrain redirects to Wikipedia Zero partner-sourced requests."

There was a huge drop in stats after this change, reverting for now to see if 
this was the cause.

This reverts commit 19594dfe596f95d4ee24e58a51d7c8a2423edda8

Change-Id: If97e0659f7df88b5c93c61fd2b4ddc4b7b7f1398
---
M includes/PageRenderingHooks.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Yurik: Verified; Looks good to me, approved



diff --git a/includes/PageRenderingHooks.php b/includes/PageRenderingHooks.php
index 731d745..4044539 100644
--- a/includes/PageRenderingHooks.php
+++ b/includes/PageRenderingHooks.php
@@ -145,7 +145,7 @@
 
                $acceptBilling = $wgRequest->getVal( 'acceptbilling' );
                // @BUG: weird code, need to check what was originally intended
-               if ( $config !== null && ( $acceptBilling === 'no' || 
$acceptBilling === 'yes' ) ) {
+               if ( $acceptBilling === 'no' || $acceptBilling === 'yes' ) {
                        $targetUrl = $wgRequest->getVal( 'returnto' );
                        if ( $targetUrl ) {
                                $out->redirect( $targetUrl, '301' );

-- 
To view, visit https://gerrit.wikimedia.org/r/70659
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If97e0659f7df88b5c93c61fd2b4ddc4b7b7f1398
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ZeroRatedMobileAccess
Gerrit-Branch: master
Gerrit-Owner: Yurik <[email protected]>
Gerrit-Reviewer: Yurik <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to