Subramanya Sastry has uploaded a new change for review.
https://gerrit.wikimedia.org/r/70664
Change subject: (Bug 50224) <source> is considered an ext-tag => it isn't a
void elt
......................................................................
(Bug 50224) <source> is considered an ext-tag => it isn't a void elt
* Because of Bug 47579, 1467925e stopped tokenizing <source> as
a HTML element, but left behind the check for <source> as a
void (self-closing) element.
* This broke the tokenizing of <source> ... </source> extension
use as reported in the bug.
* Bug fixed. No change in parser tests.
Change-Id: I0de1e49e2fdff76874ca48f88d8b8bb4ff75e923
---
M js/lib/mediawiki.Util.js
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid
refs/changes/64/70664/1
diff --git a/js/lib/mediawiki.Util.js b/js/lib/mediawiki.Util.js
index bd9d506..ae275d6 100644
--- a/js/lib/mediawiki.Util.js
+++ b/js/lib/mediawiki.Util.js
@@ -217,9 +217,13 @@
return name === 'td' || name === 'th';
},
+ // We are currently treating <source> as an extension tag since this is
widely
+ // used on wikipedias. So, we dont want to treat this as a HTML tag =>
it cannot
+ // be a void element
+ //
// See http://www.whatwg.org/specs/web-apps/current-work/#void-elements
voidElements: { area: 1, base: 1, br: 1, col: 1, command: 1, embed: 1,
hr: 1, img: 1,
- input: 1, keygen: 1, link: 1, meta: 1, param: 1, source: 1,
track: 1, wbr: 1 },
+ input: 1, keygen: 1, link: 1, meta: 1, param: 1, /* source: 1,
*/ track: 1, wbr: 1 },
/*
* Determine if the tag is an empty HTML tag
--
To view, visit https://gerrit.wikimedia.org/r/70664
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0de1e49e2fdff76874ca48f88d8b8bb4ff75e923
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
