jenkins-bot has submitted this change and it was merged.
Change subject: Escape tooltip only once
......................................................................
Escape tooltip only once
Escaping the tooltip once (in Html::rawElement) is neough. No need to feed this
method already escaped text.
Change-Id: I6229c6cfb9ced2472047c39cfc8be76c73a50f09
---
M includes/SF_FormUtils.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Foxtrott: Checked; Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/SF_FormUtils.php b/includes/SF_FormUtils.php
index 8103127..507c27e 100644
--- a/includes/SF_FormUtils.php
+++ b/includes/SF_FormUtils.php
@@ -137,7 +137,7 @@
$attrs['disabled'] = true;
}
$text = "\t" . Xml::check( 'wpWatchthis', $is_checked, $attrs )
. "\n";
- $tooltip = wfMessage( 'tooltip-watch' )->escaped();
+ $tooltip = wfMessage( 'tooltip-watch' )->text();
$text .= "\t" . Html::rawElement( 'label', array(
'for' => 'wpWatchthis',
'title' => $tooltip
--
To view, visit https://gerrit.wikimedia.org/r/70665
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6229c6cfb9ced2472047c39cfc8be76c73a50f09
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/SemanticForms
Gerrit-Branch: master
Gerrit-Owner: Foxtrott <[email protected]>
Gerrit-Reviewer: Foxtrott <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
