Matmarex has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/70681


Change subject: Allow enforcing whitelist with a cookie
......................................................................

Allow enforcing whitelist with a cookie

Check for a 'vewhitelist' cookie in addition to 'vewhitelist' URI
parameter.

This is for weirdos like me who really want to play with VE on
unsupported browsers. Adding ?vewhitelist=1 every time is just
annoying.

Using document.cookie directly to avoid loading additional libraries.

Change-Id: Ic1970f527eb49ead4e32a258a53fc2c6615c8f24
---
M modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/81/70681/1

diff --git a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js 
b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
index 3c10afa..c360df9 100644
--- a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
@@ -100,11 +100,11 @@
        this.tabLayout = mw.config.get( 'wgVisualEditorConfig' ).tabLayout;
 
        browserWhitelisted = (
-               'vewhitelist' in currentUri.query ||
+               ( 'vewhitelist' in currentUri.query || /(; 
?|^)vewhitelist=/.test( document.cookie ) ) ||
                $.client.test( 
ve.init.mw.ViewPageTarget.compatibility.whitelist, null, true )
        );
        browserBlacklisted = (
-               !( 'vewhitelist' in currentUri.query ) &&
+               !( 'vewhitelist' in currentUri.query || /(; 
?|^)vewhitelist=/.test( document.cookie ) ) &&
                $.client.test( 
ve.init.mw.ViewPageTarget.compatibility.blacklist, null, true )
        );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/70681
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1970f527eb49ead4e32a258a53fc2c6615c8f24
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Matmarex <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to