Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/70739
Change subject: Bug 49208: Make sure edit link targets the correct section
......................................................................
Bug 49208: Make sure edit link targets the correct section
Change-Id: I2e2952b65f65005cd30fad9401cf6d5ad719f38a
---
M javascripts/modules/editor/editor.js
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/39/70739/1
diff --git a/javascripts/modules/editor/editor.js
b/javascripts/modules/editor/editor.js
index 7f49804..442942e 100644
--- a/javascripts/modules/editor/editor.js
+++ b/javascripts/modules/editor/editor.js
@@ -35,11 +35,12 @@
addEditButton( 1, '#ca-edit' );
}
- $( '.section_heading' ).each( function( i ) {
+ $( '.section_heading' ).each( function() {
+ var section_id = $( this ).attr( 'id' ).split( '_' )[ 1
];
// Avoid Bug 49780
// FIXME: Addressing bug 40678 will render this
unnecessary
- if ( $( this ).attr( 'id' ) !== 'section_language' ) {
- addEditButton( i + 1, this );
+ if ( section_id && section_id !== 'language' ) {
+ addEditButton( section_id, this );
}
} );
}
--
To view, visit https://gerrit.wikimedia.org/r/70739
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e2952b65f65005cd30fad9401cf6d5ad719f38a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
