Aaron Schulz has submitted this change and it was merged.

Change subject: (bug 49840) Moving a page with subpages may lead in the page 
being moved twice
......................................................................


(bug 49840) Moving a page with subpages may lead in the page being moved twice

This happens if a page is moved to a subpage of itself and the option
"move subpages" is enabled, since the freshly moved page will be found
as being one of its subpages and moved a second time as such.

Bug: 49840
Change-Id: I318aab8c3c6e7ae718a3366ab00aba6e5420529b
---
M includes/specials/SpecialMovepage.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/specials/SpecialMovepage.php 
b/includes/specials/SpecialMovepage.php
index 2ba3c06..ccc2bf2 100644
--- a/includes/specials/SpecialMovepage.php
+++ b/includes/specials/SpecialMovepage.php
@@ -624,7 +624,7 @@
                $extraOutput = array();
                $count = 1;
                foreach ( $extraPages as $oldSubpage ) {
-                       if ( $ot->equals( $oldSubpage ) ) {
+                       if ( $ot->equals( $oldSubpage ) || $nt->equals( 
$oldSubpage ) ) {
                                # Already did this one.
                                continue;
                        }

-- 
To view, visit https://gerrit.wikimedia.org/r/70743
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I318aab8c3c6e7ae718a3366ab00aba6e5420529b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: IAlex <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to