J has uploaded a new change for review.
https://gerrit.wikimedia.org/r/70757
Change subject: ID3Handler::getID3 should be protected
......................................................................
ID3Handler::getID3 should be protected
Change-Id: I52e3004623d976192f98e2990135ef672b44c590
---
M handlers/ID3Handler/ID3Handler.php
M handlers/Mp4Handler/Mp4Handler.php
M handlers/WebMHandler/WebMHandler.php
3 files changed, 11 insertions(+), 3 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler
refs/changes/57/70757/1
diff --git a/handlers/ID3Handler/ID3Handler.php
b/handlers/ID3Handler/ID3Handler.php
index afdac09..6ebcda3 100644
--- a/handlers/ID3Handler/ID3Handler.php
+++ b/handlers/ID3Handler/ID3Handler.php
@@ -10,7 +10,7 @@
* @param $path string
* @return array
*/
- private function getID3( $path ) {
+ protected function getID3( $path ) {
// Create new id3 object:
$getID3 = new getID3();
diff --git a/handlers/Mp4Handler/Mp4Handler.php
b/handlers/Mp4Handler/Mp4Handler.php
index 791e7cd..de1958c 100644
--- a/handlers/Mp4Handler/Mp4Handler.php
+++ b/handlers/Mp4Handler/Mp4Handler.php
@@ -4,7 +4,11 @@
*/
class Mp4Handler extends ID3Handler {
- private function getID3( $path ) {
+ /**
+ * @param $path string
+ * @return array
+ */
+ protected function getID3( $path ) {
$id3 = parent::getID3( $path );
// Unset some parts of id3 that are too detailed and matroska
specific:
unset( $id3['quicktime'] );
diff --git a/handlers/WebMHandler/WebMHandler.php
b/handlers/WebMHandler/WebMHandler.php
index c68741d..356755c 100644
--- a/handlers/WebMHandler/WebMHandler.php
+++ b/handlers/WebMHandler/WebMHandler.php
@@ -4,7 +4,11 @@
*/
class WebMHandler extends ID3Handler {
- private function getID3( $path ) {
+ /**
+ * @param $path string
+ * @return array
+ */
+ protected function getID3( $path ) {
$id3 = parent::getID3( $path );
// Unset some parts of id3 that are too detailed and matroska
specific:
unset( $id3['matroska'] );
--
To view, visit https://gerrit.wikimedia.org/r/70757
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I52e3004623d976192f98e2990135ef672b44c590
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: J <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
