jenkins-bot has submitted this change and it was merged. Change subject: Change autocomment-prefix to be blank. Looks weird being '- ' ......................................................................
Change autocomment-prefix to be blank. Looks weird being '- ' This messages inserts stuff before the special formatting in /* header */ comments, if it is not the first thing in the edit summary. I'm assuming putting a dash there made sense originally, but now with the → it looks kind of weird imo. Also it can be confused since '-' is often taken to mean removal of content. I was considering using '-' to disable the message as is normally done, but in this case - is a reasonable value (and pretty close to the old value). Request by accolade on irc Change-Id: I2622b35e712120dc171ea44a887d6b42286f2a06 --- M languages/messages/MessagesEn.php M tests/parser/parserTests.txt 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Matmarex: Looks good to me, approved jenkins-bot: Verified diff --git a/languages/messages/MessagesEn.php b/languages/messages/MessagesEn.php index 6e0ecb5..4989b81 100644 --- a/languages/messages/MessagesEn.php +++ b/languages/messages/MessagesEn.php @@ -4590,7 +4590,7 @@ 'semicolon-separator' => '; ', # only translate this message to other languages if you have to change it 'comma-separator' => ', ', # only translate this message to other languages if you have to change it 'colon-separator' => ': ', # only translate this message to other languages if you have to change it -'autocomment-prefix' => '- ', # only translate this message to other languages if you have to change it +'autocomment-prefix' => '', # only translate this message to other languages if you have to change it 'pipe-separator' => ' | ', # only translate this message to other languages if you have to change it 'word-separator' => ' ', # only translate this message to other languages if you have to change it 'ellipsis' => '...', # only translate this message to other languages if you have to change it diff --git a/tests/parser/parserTests.txt b/tests/parser/parserTests.txt index f7296bd..3aca2e0 100644 --- a/tests/parser/parserTests.txt +++ b/tests/parser/parserTests.txt @@ -13058,7 +13058,7 @@ !! input pre-comment text /* External links */ removed bogus entries !! result -pre-comment text - <a href="/wiki/Main_Page#External_links" title="Main Page">→</a><span dir="auto"><span class="autocomment">External links: </span> removed bogus entries</span> +pre-comment text <a href="/wiki/Main_Page#External_links" title="Main Page">→</a><span dir="auto"><span class="autocomment">External links: </span> removed bogus entries</span> !!end !! test -- To view, visit https://gerrit.wikimedia.org/r/66883 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2622b35e712120dc171ea44a887d6b42286f2a06 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Brian Wolff <[email protected]> Gerrit-Reviewer: Brian Wolff <[email protected]> Gerrit-Reviewer: Matmarex <[email protected]> Gerrit-Reviewer: Umherirrender <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
