Mdale has submitted this change and it was merged.

Change subject: handle case where getStreamTypes returns no types
......................................................................


handle case where getStreamTypes returns no types

Change-Id: Icff4b3fec5994f1d26355101b7cd7b11de2536cc
---
M WebVideoTranscode/WebVideoTranscode.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Mdale: Verified; Looks good to me, approved
  Rahul21: Looks good to me, but someone else must approve
  jenkins-bot: Checked



diff --git a/WebVideoTranscode/WebVideoTranscode.php 
b/WebVideoTranscode/WebVideoTranscode.php
index 54675f9..555ac3b 100644
--- a/WebVideoTranscode/WebVideoTranscode.php
+++ b/WebVideoTranscode/WebVideoTranscode.php
@@ -427,9 +427,9 @@
 
                if( $file->getHandler()->isAudio( $file ) ){
                        $sourceCodec = $file->getHandler()->getStreamTypes( 
$file );
-                       $sourceCodec = strtolower($sourceCodec[0]);
+                       $sourceCodec = $sourceCodec ? strtolower( 
$sourceCodec[0] ) : '';
                        foreach( $wgEnabledAudioTranscodeSet as $transcodeKey ){
-                               $codec =  
self::$derivativeSettings[$transcodeKey]['audioCodec'];
+                               $codec = 
self::$derivativeSettings[$transcodeKey]['audioCodec'];
                                if ( $sourceCodec != $codec ) {
                                        // Try and add the source
                                        self::addSourceIfReady( $file, 
$sources, $transcodeKey, $options );

-- 
To view, visit https://gerrit.wikimedia.org/r/70765
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icff4b3fec5994f1d26355101b7cd7b11de2536cc
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: J <[email protected]>
Gerrit-Reviewer: Brian Wolff <[email protected]>
Gerrit-Reviewer: Mdale <[email protected]>
Gerrit-Reviewer: Rahul21 <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to