jenkins-bot has submitted this change and it was merged.
Change subject: Impl isWriteMode() for claim modules.
......................................................................
Impl isWriteMode() for claim modules.
All API modules that change the database should return true from isWriteMode().
Change-Id: If989c34bfd4ca3e50beb888507a774351e7c46b4
---
M repo/includes/api/ModifyClaim.php
M repo/includes/api/RemoveClaims.php
M repo/includes/api/SetClaim.php
M repo/includes/api/SetClaimValue.php
4 files changed, 31 insertions(+), 10 deletions(-)
Approvals:
Tobias Gritschacher: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/includes/api/ModifyClaim.php
b/repo/includes/api/ModifyClaim.php
index a7892a8..624254d 100644
--- a/repo/includes/api/ModifyClaim.php
+++ b/repo/includes/api/ModifyClaim.php
@@ -58,4 +58,12 @@
return $summary;
}
+ /**
+ * @see ApiBase::isWriteMode
+ * @return bool true
+ */
+ public function isWriteMode() {
+ return true;
+ }
+
}
diff --git a/repo/includes/api/RemoveClaims.php
b/repo/includes/api/RemoveClaims.php
index 155db87..4883629 100644
--- a/repo/includes/api/RemoveClaims.php
+++ b/repo/includes/api/RemoveClaims.php
@@ -44,9 +44,13 @@
*/
class RemoveClaims extends ApiWikibase {
- // TODO: example
- // TODO: rights
- // TODO: conflict detection
+ /**
+ * @see ApiBase::isWriteMode
+ * @return bool true
+ */
+ public function isWriteMode() {
+ return true;
+ }
/**
* @see \ApiBase::execute
diff --git a/repo/includes/api/SetClaim.php b/repo/includes/api/SetClaim.php
index b724df3..bd4f131 100644
--- a/repo/includes/api/SetClaim.php
+++ b/repo/includes/api/SetClaim.php
@@ -48,8 +48,6 @@
*/
class SetClaim extends ApiWikibase {
- // TODO: rights
-
/**
* @var SnakValidationHelper
*/
@@ -74,6 +72,14 @@
}
/**
+ * @see ApiBase::isWriteMode
+ * @return bool true
+ */
+ public function isWriteMode() {
+ return true;
+ }
+
+ /**
* @see ApiBase::execute
*
* @since 0.4
diff --git a/repo/includes/api/SetClaimValue.php
b/repo/includes/api/SetClaimValue.php
index c22f0b3..4204ccc 100644
--- a/repo/includes/api/SetClaimValue.php
+++ b/repo/includes/api/SetClaimValue.php
@@ -47,11 +47,6 @@
*/
class SetClaimValue extends ApiWikibase implements IAutocomment{
- // TODO: example
- // TODO: rights
- // TODO: conflict detection
- // TODO: claim uniqueness
-
/**
* @var SnakValidationHelper
*/
@@ -76,6 +71,14 @@
}
/**
+ * @see ApiBase::isWriteMode
+ * @return bool true
+ */
+ public function isWriteMode() {
+ return true;
+ }
+
+ /**
* @see \ApiBase::execute
*
* @since 0.3
--
To view, visit https://gerrit.wikimedia.org/r/70816
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If989c34bfd4ca3e50beb888507a774351e7c46b4
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Denny Vrandecic <denny.vrande...@wikimedia.de>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
