jenkins-bot has submitted this change and it was merged.
Change subject: Don't prefix an empty transclusion parameter value with a space
......................................................................
Don't prefix an empty transclusion parameter value with a space
Change-Id: I225dcf06eadd57512ed2a96856604b9db7b73bae
---
M js/lib/mediawiki.WikitextSerializer.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Subramanya Sastry: Looks good to me, approved
jenkins-bot: Verified
diff --git a/js/lib/mediawiki.WikitextSerializer.js
b/js/lib/mediawiki.WikitextSerializer.js
index afdeb7f..03f0e60 100644
--- a/js/lib/mediawiki.WikitextSerializer.js
+++ b/js/lib/mediawiki.WikitextSerializer.js
@@ -2698,10 +2698,10 @@
if
(!/\s$/.test(k)) {
kStr = kStr + ' ';
}
- if
(!/^\s/.test(v)) {
+ if
(vStr && !/^\s/.test(v)) {
vStr = ' ' + vStr;
}
- } else if
(k.match(/\s$/) && !v.match(/^\s/)) {
+ } else if
(k.match(/\s$/) && vStr && !v.match(/^\s/)) {
// Only
prefix value with space if key
// ends
with space too
vStr =
' ' + vStr;
--
To view, visit https://gerrit.wikimedia.org/r/70832
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I225dcf06eadd57512ed2a96856604b9db7b73bae
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: GWicke <gwi...@wikimedia.org>
Gerrit-Reviewer: Subramanya Sastry <ssas...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
