Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/70865


Change subject: Fix escapeParams in transclusions to not escape other 
transclusions
......................................................................

Fix escapeParams in transclusions to not escape other transclusions

Just a breaking test so far.

Bug: 49854
Change-Id: Ic0b97520b1696c3cf292111c7052502d5ccad648
---
M modules/ve/test/dm/nodes/ve.dm.MWTransclusionNode.test.js
1 file changed, 10 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/65/70865/1

diff --git a/modules/ve/test/dm/nodes/ve.dm.MWTransclusionNode.test.js 
b/modules/ve/test/dm/nodes/ve.dm.MWTransclusionNode.test.js
index c26fa52..190d0bc 100644
--- a/modules/ve/test/dm/nodes/ve.dm.MWTransclusionNode.test.js
+++ b/modules/ve/test/dm/nodes/ve.dm.MWTransclusionNode.test.js
@@ -61,6 +61,16 @@
                                }
                        },
                        'wikitext': '{{foo|bar=You should try using 
<nowiki>{{ping|foo=bar|2=1}}</nowiki> as a transclusion!}}'
+               },
+               {
+                       'msg': 'parameter containing another template 
invocation',
+                       'mw': {
+                               'target': { 'wt': 'foo' },
+                               'params': {
+                                       'bar': { 'wt': '{{ping|foo=bar|2=1}}' }
+                               }
+                       },
+                       'wikitext': '{{foo|bar={{ping|foo=bar|2=1}}}}'
                }
        ];
        QUnit.expect( cases.length );

-- 
To view, visit https://gerrit.wikimedia.org/r/70865
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0b97520b1696c3cf292111c7052502d5ccad648
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to