Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/70933


Change subject: Fix logic for populating reference content
......................................................................

Fix logic for populating reference content

Force clearing of mwData.body if setContents is unset, and clear
mwOriginal when cloning.

Change-Id: I3150b5da7b50e14f400602c5842994e242ad182a
---
M modules/ve/dm/nodes/ve.dm.MWReferenceNode.js
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/33/70933/1

diff --git a/modules/ve/dm/nodes/ve.dm.MWReferenceNode.js 
b/modules/ve/dm/nodes/ve.dm.MWReferenceNode.js
index 9591f1f..ae6b80f 100644
--- a/modules/ve/dm/nodes/ve.dm.MWReferenceNode.js
+++ b/modules/ve/dm/nodes/ve.dm.MWReferenceNode.js
@@ -115,6 +115,8 @@
                if ( !$( '<div>' ).html( originalHtml ).get( 0 ).isEqualNode( 
itemNodeWrapper ) ) {
                        ve.setProp( mwData, 'body', 'html', itemNodeHtml );
                }
+       } else {
+               delete mwData.body;
        }
 
        // Set or clear key
@@ -210,6 +212,7 @@
 ve.dm.MWReferenceNode.prototype.getClonedElement = function () {
        var clone = ve.dm.LeafNode.prototype.getClonedElement.call( this );
        delete clone.attributes.contentsUsed;
+       delete clone.attributes.originalMw;
        return clone;
 };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/70933
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3150b5da7b50e14f400602c5842994e242ad182a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to