jenkins-bot has submitted this change and it was merged.
Change subject: Remove useless HTML comments
......................................................................
Remove useless HTML comments
They are not needed. The code is indented and when inspecting code in
Chrome Developer Tools or Firebug, they provide absolutely no value.
Plus, we don't strip them in production.
Change-Id: I2cad742d26a6bbe50e8f21a26b2b562df37c6e83
---
M includes/skins/MinervaTemplate.php
M includes/skins/MobileTemplateBeta.php
2 files changed, 6 insertions(+), 7 deletions(-)
Approvals:
MaxSem: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/skins/MinervaTemplate.php
b/includes/skins/MinervaTemplate.php
index e4303fe..f05c05d 100644
--- a/includes/skins/MinervaTemplate.php
+++ b/includes/skins/MinervaTemplate.php
@@ -112,8 +112,8 @@
$this->renderLanguages();
$this->renderHistoryLink( $data );
?>
- </div><!-- close #content -->
- </div><!-- close #content_wrapper -->
+ </div>
+ </div>
<?php
}
@@ -149,7 +149,6 @@
?>
</div>
<div id='mw-mf-page-center'>
- <!-- start -->
<?php
foreach( $this->data['banners'] as
$banner ):
echo $banner;
@@ -177,8 +176,8 @@
$this->renderContentWrapper( $data );
$this->renderFooter( $data );
?>
- </div><!-- close #mw-mf-page-center -->
- </div><!-- close #mw-mf-viewport -->
+ </div>
+ </div>
<?php
echo $data['reporttime'];
echo $data['bottomscripts'];
diff --git a/includes/skins/MobileTemplateBeta.php
b/includes/skins/MobileTemplateBeta.php
index 66492d0..d5692ce 100644
--- a/includes/skins/MobileTemplateBeta.php
+++ b/includes/skins/MobileTemplateBeta.php
@@ -46,8 +46,8 @@
$this->renderLanguages( $data );
$this->renderHistoryLink( $data );
?>
- </div><!-- close #content -->
- </div><!-- close #content_wrapper -->
+ </div>
+ </div>
<?php
}
}
--
To view, visit https://gerrit.wikimedia.org/r/70935
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2cad742d26a6bbe50e8f21a26b2b562df37c6e83
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
