jenkins-bot has submitted this change and it was merged.
Change subject: Reset transclusion / file caches to {} instead of undefined
......................................................................
Reset transclusion / file caches to {} instead of undefined
Fixes crasher in production on template / file update.
Change-Id: I986584334abbd13eb937d107ed825be034e0713e
---
M js/api/ParserService.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Subramanya Sastry: Looks good to me, approved
jenkins-bot: Verified
diff --git a/js/api/ParserService.js b/js/api/ParserService.js
index 55c81e1..006daea 100644
--- a/js/api/ParserService.js
+++ b/js/api/ParserService.js
@@ -279,10 +279,10 @@
if (parsoidHeader.cacheID) {
if (parsoidHeader.mode === 'templates') {
// Transclusions need to be updated, so don't reuse
them.
- expansions.transclusions = undefined;
+ expansions.transclusions = {};
} else if (parsoidHeader.mode === 'files') {
// Files need to be updated, so don't reuse them.
- expansions.files = undefined;
+ expansions.files = {};
}
}
--
To view, visit https://gerrit.wikimedia.org/r/71130
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I986584334abbd13eb937d107ed825be034e0713e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: GWicke <[email protected]>
Gerrit-Reviewer: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
