jenkins-bot has submitted this change and it was merged.
Change subject: Ensure the toast lasts for at least a second
......................................................................
Ensure the toast lasts for at least a second
Currently a scroll event can hide it without the user having
seen it. This can happen when an overlay closes
Change-Id: I6fb63869825a5fd6b2352471cd6111a73e3f6db1
---
M javascripts/common/mf-notification.js
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
JGonera: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/common/mf-notification.js
b/javascripts/common/mf-notification.js
index 9c4480f..81542e9 100644
--- a/javascripts/common/mf-notification.js
+++ b/javascripts/common/mf-notification.js
@@ -1,6 +1,7 @@
( function( M, $ ) {
var m = ( function() {
var calculatePosition = function() {},
+ canCancel = true,
inBeta = mw.config.get( 'wgMFMode' ) === 'beta';
if ( !M.supportsPositionFixed() ) {
@@ -20,6 +21,10 @@
}
function show( html, classes ) {
+ canCancel = false;
+ window.setTimeout( function() {
+ canCancel = true;
+ }, 1000 );
$( '#mf-notification div' ).html( html );
calculatePosition();
return $( '#mf-notification' ).
@@ -30,7 +35,7 @@
function close( forceClose ) {
var $notification = $( '#mf-notification' );
- if ( !$notification.hasClass( 'visible' ) ) {
+ if ( !$notification.hasClass( 'visible' ) || !canCancel
) {
return;
} else if ( !$notification.hasClass( 'locked' ) ||
forceClose ) {
$( '#mf-notification' ).removeClass( 'visible'
);
--
To view, visit https://gerrit.wikimedia.org/r/71150
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6fb63869825a5fd6b2352471cd6111a73e3f6db1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: JGonera <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
