jenkins-bot has submitted this change and it was merged.
Change subject: Add support for WAV audio files (Fixed a small typo and made
some minor changes to the i18n and qqq messages)
......................................................................
Add support for WAV audio files (Fixed a small typo and made some minor changes
to the i18n and qqq messages)
Bug: 32135
Change-Id: I3ca39c5c91dafcc7ee3468c8494dc6214bc3235c
---
M TimedMediaHandler.i18n.php
M handlers/WAVHandler/WAVHandler.php
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Mattflaschen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/TimedMediaHandler.i18n.php b/TimedMediaHandler.i18n.php
index 05c33ed..9b7f628 100755
--- a/TimedMediaHandler.i18n.php
+++ b/TimedMediaHandler.i18n.php
@@ -26,6 +26,7 @@
'timedmedia-wav-short-audio' => 'WAV audio file, $1',
'timedmedia-wav-long-audio' => 'WAV audio file, length $1, $2 overall',
+ 'timedmedia-wav-pcm-required' => 'You can only upload PCM (Pulse Code
Modulation) WAV.',
'timedmedia-mp4-short-video' => 'MP4 $1 video file, $2',
'timedmedia-mp4-long-video' => 'MP4 audio/video file, $1, length $2, $4
× $5 pixels, $3 overall',
@@ -40,7 +41,6 @@
'timedmedia-desc-link' => 'About this file',
'timedmedia-oggThumb-version' => 'OggHandler requires oggThumb version
$1 or later.',
'timedmedia-oggThumb-failed' => 'oggThumb failed to create the
thumbnail.',
- 'timedmedia-wav-pcm-required' => 'You can only upload PCM (Pulse Code
Modulation) WAV.',
// Transcode status table:
@@ -249,6 +249,7 @@
Shown after the filename in the image description page.
See also:
* {{msg-mw|Timedmedia-wav-short-audio}}',
+ 'timedmedia-wav-pcm-required' => 'Message shown at upload if user tries
to upload a WAV file using a codec that is not PCM',
'timedmedia-flac-short-audio' => 'File details for FLAC audio files,
short version.
Parameters:
@@ -413,7 +414,6 @@
'right-transcode-reset' => '{{doc-right|transcode-reset}}',
'right-transcode-status' => '{{doc-right|transcode-status}}', # Fuzzy
'action-transcode-status' => '{{doc-action|transcode-status}}', # Fuzzy
- 'timedmedia-wav-pcm-required' => 'Message shown at upload if user tries
to upload a WAV file using a codec that is not PCM',
);
/** Afrikaans (Afrikaans)
diff --git a/handlers/WAVHandler/WAVHandler.php
b/handlers/WAVHandler/WAVHandler.php
index e8fc696..8e1c2c7 100755
--- a/handlers/WAVHandler/WAVHandler.php
+++ b/handlers/WAVHandler/WAVHandler.php
@@ -22,7 +22,7 @@
function verifyUpload( $filename ) {
$metadata = $this->getID3( $filename );
- if( issset( $metadata['audio'] ) &&
$metadata['audio']['dataformat'] == 'wav' && $metadata['audio']['codec'] ==
'Pulse Code Modulation (PCM)') {
+ if( isset( $metadata['audio'] ) &&
$metadata['audio']['dataformat'] == 'wav' && $metadata['audio']['codec'] ==
'Pulse Code Modulation (PCM)') {
return Status::newGood();
}
return Status::newFatal( 'timedmedia-wav-pcm-required' );
--
To view, visit https://gerrit.wikimedia.org/r/71129
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ca39c5c91dafcc7ee3468c8494dc6214bc3235c
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Rahul21 <[email protected]>
Gerrit-Reviewer: J <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: Mdale <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
