jenkins-bot has submitted this change and it was merged.
Change subject: Bug 49711: Add debug print when dsr on wrapper is missing
......................................................................
Bug 49711: Add debug print when dsr on wrapper is missing
TODO: Add generic env.warn and env.error methods that both print the page name
and prefix implicitly.
Change-Id: I54cdd793f04612b124fc3065df2325e7d14729df
---
M js/lib/mediawiki.DOMPostProcessor.js
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Subramanya Sastry: Looks good to me, approved
jenkins-bot: Verified
diff --git a/js/lib/mediawiki.DOMPostProcessor.js
b/js/lib/mediawiki.DOMPostProcessor.js
index 1a66490..3b71c32 100644
--- a/js/lib/mediawiki.DOMPostProcessor.js
+++ b/js/lib/mediawiki.DOMPostProcessor.js
@@ -2578,7 +2578,7 @@
* DOMTraverser handler that unpacks DOM fragments which were injected in the
* token pipeline.
*/
-function unpackDOMFragments(node) {
+function unpackDOMFragments(env, node) {
if (node.nodeType === node.ELEMENT_NODE) {
var typeOf = node.getAttribute('typeof'),
about = node.getAttribute('about'),
@@ -2682,6 +2682,8 @@
addDeltaToDSR(firstChild,
tsrDelta);
}
}
+ } else {
+ console.error( 'ERROR in ' + env.page.name + ':
no DOMFragment wrapper dsr on ' + node.outerHTML );
}
// Move the old content nodes over from the dummyNode
@@ -2947,7 +2949,7 @@
// 3. Unpack DOM fragments (reused transclusion and extension content)
var lastDOMHandler = new DOMTraverser();
lastDOMHandler.addHandler( 'a', handleLinkNeighbours.bind( null, env )
);
- lastDOMHandler.addHandler( null, unpackDOMFragments );
+ lastDOMHandler.addHandler( null, unpackDOMFragments.bind(null, env) );
this.processors.push(lastDOMHandler.traverse.bind(lastDOMHandler));
// A pure DOM transformation
--
To view, visit https://gerrit.wikimedia.org/r/71166
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I54cdd793f04612b124fc3065df2325e7d14729df
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: GWicke <[email protected]>
Gerrit-Reviewer: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
