Rtdwivedi has uploaded a new change for review.
https://gerrit.wikimedia.org/r/71172
Change subject: Added unit tests for Page pages.
......................................................................
Added unit tests for Page pages.
Change-Id: Ic80a32efc181c2b9b963653bdf2fbced56576706
---
M ProofreadPage.php
M includes/page/ProofreadPageContent.php
M includes/page/ProofreadPagePage.php
A tests/includes/page/ProofreadPagePageTest.php
4 files changed, 70 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage
refs/changes/72/71172/1
diff --git a/ProofreadPage.php b/ProofreadPage.php
index ef346b1..9d21c3f 100644
--- a/ProofreadPage.php
+++ b/ProofreadPage.php
@@ -51,7 +51,7 @@
$wgAutoloadClasses['ProofreadPageDbConnector'] = $dir .
'includes/page/ProofreadPageDbConnector.php';
$wgAutoloadClasses['EditProofreadPagePage'] = $dir .
'includes/page/EditProofreadPagePage.php';
$wgAutoloadClasses['ProofreadPagePage'] =
$dir.'includes/page/ProofreadPagePage.php';
-$wgAutoloadClasses['ProofreadPageValue'] =
$dir.'includes/page/ProofreadPageValue.php';
+$wgAutoloadClasses['ProofreadPageContent'] =
$dir.'includes/page/ProofreadPageContent.php';
$wgExtensionCredits['other'][] = array(
'path' => __FILE__,
@@ -168,6 +168,8 @@
$files[] = $dir . 'index/ProofreadIndexPageTest.php';
+ $files[] = $dir . 'page/ProofreadPagePageTest.php';
+
return true;
};
diff --git a/includes/page/ProofreadPageContent.php
b/includes/page/ProofreadPageContent.php
index 15a60f3..9e4cc9b 100644
--- a/includes/page/ProofreadPageContent.php
+++ b/includes/page/ProofreadPageContent.php
@@ -147,7 +147,7 @@
* Sets the last proofreader
* @param $proofreader User
*/
- public static function setProofreader( User $user ) {
+ public function setProofreader( User $user ) {
$this->proofreader = $user;
}
@@ -156,7 +156,7 @@
* @param $name string
* @throws MWException
*/
- public static function setProofreaderFromName( $name ) {
+ public function setProofreaderFromName( $name ) {
if ( $name === '' ) {
$this->proofreader = null;
} elseif ( IP::isValid( $name ) ) {
@@ -176,7 +176,7 @@
* @param $level integer
* @throws MWException
*/
- public static function setLevel( $level ) {
+ public function setLevel( $level ) {
if ( !is_integer( $level ) || $level < 0 || $level > 4 ) {
throw new MWException( 'level must be an integer
between 0 and 4.' );
}
diff --git a/includes/page/ProofreadPagePage.php
b/includes/page/ProofreadPagePage.php
index 509465c..f8c3d49 100644
--- a/includes/page/ProofreadPagePage.php
+++ b/includes/page/ProofreadPagePage.php
@@ -71,7 +71,7 @@
* Returns number of the page in the file if it's a multi-page file or
null
* @return integer|null
*/
- protected function getPageNumber() {
+ public function getPageNumber() {
$parts = explode( '/', $this->title->getText() );
if ( count( $parts ) === 1 ) {
return null;
@@ -139,7 +139,7 @@
/**
* Return content of the page initialised for edition
- * @return ProofreadPageValue
+ * @return ProofreadPageContent
*/
public function getContentForEdition() {
global $wgContLang;
@@ -147,7 +147,7 @@
if ( $content->isEmpty() ) {
$index = $this->getIndex();
if ( $index ) {
- list( $header, $footer, $css, $editWidth ) =
$index->getIndexDataForPage();
+ list( $header, $footer, $css, $editWidth ) =
$index->getIndexDataForPage( $this->title );
$content->setHeader( $header );
$content->setFooter( $footer );
diff --git a/tests/includes/page/ProofreadPagePageTest.php
b/tests/includes/page/ProofreadPagePageTest.php
new file mode 100644
index 0000000..1e092bb
--- /dev/null
+++ b/tests/includes/page/ProofreadPagePageTest.php
@@ -0,0 +1,61 @@
+<?php
+
+/**
+ * @group ProofreadPage
+ */
+class ProofreadPagePageTest extends MediawikiLangTestCase {
+
+ protected function setUp() {
+ global $wgProofreadPageNamespaceIds, $wgExtraNamespaces,
$wgNamespacesWithSubpages;
+ parent::setUp();
+
+ $wgProofreadPageNamespaceIds = array(
+ 'page' => 250,
+ 'index' => 252
+ );
+ $wgNamespacesWithSubpages[NS_MAIN] = true;
+ }
+
+ public function testNewFromTitle() {
+ $this->assertInstanceOf( 'ProofreadPagePage',
ProofreadPagePage::newFromTitle( Title::makeTitle( 250, 'Test.djvu' ) ) );
+ }
+
+ public function testGetTitle() {
+ $title = Title::makeTitle( 250, 'Test.djvu' );
+ $index = new ProofreadIndexPage( $title, array(), '' );
+ $page = new ProofreadPagePage( $title, null, $index );
+ $this->assertEquals( $title, $page->getTitle() );
+ }
+
+ public function testGetPageNumber() {
+ $title = Title::makeTitle( 250, 'Test.djvu' );
+ $index = new ProofreadIndexPage( $title, array(), '' );
+ $page = new ProofreadPagePage( $title, null, $index );
+ $this->assertInternalType('integer', $page->getPageNumber() );
+ $this->assertInternalType('null', $page->getPageNumber() );
+ }
+
+ public function testGetIndex() {
+ $title = Title::makeTitle( 250, 'Test.djvu' );
+ $index = new ProofreadIndexPage( $title, array(), '' );
+ $page = new ProofreadPagePage( $title, null, $index );
+ $this->assertEquals( $index, $page->getIndex() );
+ }
+
+
+
+ public function testGetContent() {
+ $title = Title::makeTitle( 250, 'Test.djvu' );
+ $index = new ProofreadIndexPage( $title, array(), '' );
+ $page = new ProofreadPagePage( $title, null, $index );
+ $this->assertInstanceOf( 'ProofreadPageContent',
$page->getContent() );
+ }
+
+ public function testGetContentForEdition() {
+ $title = Title::makeTitle( 250, 'Test.djvu' );
+ $index = new ProofreadIndexPage( $title, array(), '' );
+ $page = new ProofreadPagePage( $title, null, $index );
+ $this->assertInstanceOf( 'ProofreadPageContent',
$page->getContentForEdition() );
+ }
+
+}
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/71172
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic80a32efc181c2b9b963653bdf2fbced56576706
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: pagePagesRefactoring
Gerrit-Owner: Rtdwivedi <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
