MathiasLidal has uploaded a new change for review.
https://gerrit.wikimedia.org/r/71323
Change subject: Remove newline before final bracket
......................................................................
Remove newline before final bracket
The extra newline added before the final bracket will break some code,
e.g. if the last field is the name of an uploaded file (the newline will
be added to the field value, i.e. the filename)
Change-Id: Ib0da2f5e89d5d7e84ae0a4c6544b295c90e39174
---
M includes/SF_FormPrinter.php
1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticForms
refs/changes/23/71323/1
diff --git a/includes/SF_FormPrinter.php b/includes/SF_FormPrinter.php
index 9bd3162..7fe9661 100644
--- a/includes/SF_FormPrinter.php
+++ b/includes/SF_FormPrinter.php
@@ -1412,11 +1412,6 @@
// a bunch of pipes (i.e., it's an
indexed template with unused
// parameters at the end), remove the
pipes.
$template_text = preg_replace(
'/\|*$/', '', $template_text );
- // add another newline before the final
bracket, if this template
- // call is already more than one line
- if ( strpos( $template_text, "\n" ) ) {
- $template_text .= "\n";
- }
// If we're editing an existing page,
and there were fields in
// the template call not handled by
this form, preserve those.
if ( !$allow_multiple ) {
--
To view, visit https://gerrit.wikimedia.org/r/71323
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0da2f5e89d5d7e84ae0a4c6544b295c90e39174
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticForms
Gerrit-Branch: master
Gerrit-Owner: MathiasLidal <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
