jenkins-bot has submitted this change and it was merged.
Change subject: Don't underline the 'user guide' link when hovering the tool
menu
......................................................................
Don't underline the 'user guide' link when hovering the tool menu
There are wider issues about sub-tools here, but this fixes the most glaring
issue
for now.
Change-Id: I5ff2d67642daea2f84ccc56fe391eee9ca01d099
---
M modules/ve/init/mw/styles/ve.init.mw.ViewPageTarget.css
M modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
2 files changed, 3 insertions(+), 2 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/init/mw/styles/ve.init.mw.ViewPageTarget.css
b/modules/ve/init/mw/styles/ve.init.mw.ViewPageTarget.css
index c187765..e038849 100644
--- a/modules/ve/init/mw/styles/ve.init.mw.ViewPageTarget.css
+++ b/modules/ve/init/mw/styles/ve.init.mw.ViewPageTarget.css
@@ -105,7 +105,8 @@
font-variant: small-caps;
}
-.ve-init-mw-viewPageTarget-tool:hover .ve-init-mw-viewPageTarget-tool-label {
+.ve-init-mw-viewPageTarget-tool:hover .ve-init-mw-viewPageTarget-tool-label,
+.ve-init-mw-viewPageTarget-subtool-label:hover {
text-decoration: underline;
}
diff --git a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
index 599818e..6d8efd9 100644
--- a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
@@ -893,7 +893,7 @@
.append( $( '<div>' )
.addClass( 've-init-mw-viewPageTarget-tool' )
.append( $( '<span>' )
- .addClass(
've-init-mw-viewPageTarget-tool-label' )
+ .addClass(
've-init-mw-viewPageTarget-subtool-label' )
.append( $( '<a>' )
.attr( 'title', ve.msg(
'visualeditor-help-title' ) )
.attr( 'href', new mw.Title( ve.msg(
'visualeditor-help-link' ) ).getUrl() )
--
To view, visit https://gerrit.wikimedia.org/r/71386
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ff2d67642daea2f84ccc56fe391eee9ca01d099
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
