jenkins-bot has submitted this change and it was merged.
Change subject: Bug 50474: Remove children of references node
......................................................................
Bug 50474: Remove children of references node
Make sure we don't keep old references content around on re-render.
Change-Id: I79ad1e5d69ebb506078fa5903d1ff78b6ff82433
---
M js/lib/ext.Cite.js
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Subramanya Sastry: Looks good to me, approved
jenkins-bot: Verified
diff --git a/js/lib/ext.Cite.js b/js/lib/ext.Cite.js
index 82dfdbc..356750b 100644
--- a/js/lib/ext.Cite.js
+++ b/js/lib/ext.Cite.js
@@ -448,6 +448,11 @@
refsNode.setAttribute('data-mw', dataMW);
+ // Remove all children from the references node
+ while (refsNode.firstChild) {
+ refsNode.removeChild(refsNode.firstChild);
+ }
+
if (refGroup) {
refGroup.refs.map(refGroup.renderLine.bind(refGroup, refsNode));
}
--
To view, visit https://gerrit.wikimedia.org/r/71528
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79ad1e5d69ebb506078fa5903d1ff78b6ff82433
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: GWicke <[email protected]>
Gerrit-Reviewer: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
