jenkins-bot has submitted this change and it was merged.
Change subject: Blacklist Firefox <= 10 per reports that it's broken
......................................................................
Blacklist Firefox <= 10 per reports that it's broken
Bug: 50534
Change-Id: I732a6cceb0790bf22488e4db292b62c43276783f
---
M modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
M modules/ve/test/init/mw/targets/ve.init.mw.ViewPageTarget.test.js
2 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
index eb29d5c..c1bafd6 100644
--- a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
@@ -201,7 +201,10 @@
// requests to the VisualEditor/Parsoid API which is causing
silent failures
// when trying to save a page (bug 49187)
'msie': [['<=', 10]],
+ // Android 2.x and below "support" CE but don't trigger
keyboard input
'android': [['<', 3]],
+ // Bug 50534 - apparently Firefox is broken in versions 10 and
below
+ 'firefox': [['<=', 10]],
// Blacklist all versions:
'opera': null,
'blackberry': null
diff --git a/modules/ve/test/init/mw/targets/ve.init.mw.ViewPageTarget.test.js
b/modules/ve/test/init/mw/targets/ve.init.mw.ViewPageTarget.test.js
index aceccdb..19a7fc1 100644
--- a/modules/ve/test/init/mw/targets/ve.init.mw.ViewPageTarget.test.js
+++ b/modules/ve/test/init/mw/targets/ve.init.mw.ViewPageTarget.test.js
@@ -38,7 +38,7 @@
{
'msg': 'Firefox 10',
'userAgent': 'Mozilla/5.0 (X11; Mageia; Linux
x86_64; rv:10.0.9) Gecko/20100101 Firefox/10.0.9',
- 'matches': []
+ 'matches': [ 'blacklist' ]
},
{
'msg': 'Firefox 11',
--
To view, visit https://gerrit.wikimedia.org/r/71554
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I732a6cceb0790bf22488e4db292b62c43276783f
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
