Matmarex has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/71641


Change subject: Remove 'mw-editsection-bracket' hack
......................................................................

Remove 'mw-editsection-bracket' hack

Id27555c6 in mediawiki/core was merged, this is no longer needed.

Change-Id: I78b9f04c45b30b36815370f39f5e10977d76bdf4
---
M modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
1 file changed, 1 insertion(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/41/71641/1

diff --git a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js 
b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
index deb05fc..850407f 100644
--- a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
@@ -1254,7 +1254,7 @@
                        $links = $editLink.add( $editSourceLink ),
                        $divider = $( '<span>' ),
                        dividerText = $.trim( ve.msg( 'pipe-separator' ) ),
-                       $brackets = $( [ this.firstChild, this.lastChild ] );
+                       $brackets = $editsection.find( 
'.mw-editsection-bracket' );
 
                function expandSoon() {
                        // Cancel pending shrink, schedule expansion instead
@@ -1282,13 +1282,6 @@
                                $expandedOnly.css( 'visibility', 'hidden' );
                                $heading.removeClass( 'mw-editsection-expanded' 
);
                        }
-               }
-
-               // TODO: Remove this (see Id27555c6 in mediawiki/core)
-               if ( !$brackets.hasClass( 'mw-editsection-bracket' ) ) {
-                       $brackets = $brackets
-                               .wrap( $( '<span>' ).addClass( 
'mw-editsection-bracket' ) )
-                               .parent();
                }
 
                $closingBracket = $brackets.last();

-- 
To view, visit https://gerrit.wikimedia.org/r/71641
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I78b9f04c45b30b36815370f39f5e10977d76bdf4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Matmarex <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to