Bsitu has uploaded a new change for review.
https://gerrit.wikimedia.org/r/71643
Change subject: Fix two typos + one js integer casting
......................................................................
Fix two typos + one js integer casting
Change-Id: Ie5c4c39e94e5531dbfa48e8cde7b608967cec0c8
---
M formatters/UserRightsFormatter.php
M modules/overlay/ext.echo.overlay.js
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/43/71643/1
diff --git a/formatters/UserRightsFormatter.php
b/formatters/UserRightsFormatter.php
index 4c8dbb5..ed707cd 100644
--- a/formatters/UserRightsFormatter.php
+++ b/formatters/UserRightsFormatter.php
@@ -54,7 +54,7 @@
// Set up link parameters based on the destination (or pass to
parent)
switch ( $destination ) {
case 'user-rights-list':
- $target = SpeicalPage::getTitleFor(
'ListsGroupRights' );
+ $target = SpecialPage::getTitleFor(
'ListGroupRights' );
break;
default:
return parent::getLinkParams( $event, $user,
$destination );
diff --git a/modules/overlay/ext.echo.overlay.js
b/modules/overlay/ext.echo.overlay.js
index 83e8144..54d4306 100644
--- a/modules/overlay/ext.echo.overlay.js
+++ b/modules/overlay/ext.echo.overlay.js
@@ -86,7 +86,7 @@
$li.click( function() {
if (
mw.echo.clickThroughEnabled ) {
// Log the
clickthrough
-
mw.echo.logInteraction( 'notification-link-click', 'flyout', data.id, data.type
);
+
mw.echo.logInteraction( 'notification-link-click', 'flyout', +data.id,
data.type );
}
window.location.href =
$li.find( '.mw-echo-notification-primary-link' ).attr( 'href' );
} );
--
To view, visit https://gerrit.wikimedia.org/r/71643
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie5c4c39e94e5531dbfa48e8cde7b608967cec0c8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Bsitu <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
