Cmcmahon has submitted this change and it was merged.
Change subject: Fixed confusion in element names
......................................................................
Fixed confusion in element names
Change-Id: I1d75ce18a692af706e2a21a8015948898d14d71f
---
M features/page.feature
M features/step_definitions/math_steps.rb
M features/step_definitions/page_steps.rb
M features/support/pages/does_not_exist_page.rb
4 files changed, 10 insertions(+), 10 deletions(-)
Approvals:
Cmcmahon: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/features/page.feature b/features/page.feature
index eabf94d..975f5f7 100644
--- a/features/page.feature
+++ b/features/page.feature
@@ -11,7 +11,7 @@
Scenario: Prepare to start a new page using the URL
Given I am at page that does not exist
- When I click link Create
+ When I click link Create source
Then edit page should open
And text box with page text should be there
And Save button should be there
@@ -21,7 +21,7 @@
Scenario: Start a new page using the URL
Given I am at page that does not exist
- When I click link Create
+ When I click link Create source
And I enter article text
And I click Save page button
Then newly created page should open
diff --git a/features/step_definitions/math_steps.rb
b/features/step_definitions/math_steps.rb
index 18e7dad..1994ba5 100644
--- a/features/step_definitions/math_steps.rb
+++ b/features/step_definitions/math_steps.rb
@@ -1,7 +1,7 @@
Given(/^I am editing page that does not exist$/) do
step 'I am at page that does not exist'
- step 'I click link Create'
+ step 'I click link Create source'
end
When(/^I type (.+)$/) do |write_text|
diff --git a/features/step_definitions/page_steps.rb
b/features/step_definitions/page_steps.rb
index 54e5f06..8667ae4 100644
--- a/features/step_definitions/page_steps.rb
+++ b/features/step_definitions/page_steps.rb
@@ -2,8 +2,8 @@
visit(DoesNotExistPage, using_params: {page_name: @does_not_exist_page_name})
end
-When(/^I click link Create$/) do
- on(DoesNotExistPage).create
+When(/^I click link Create source$/) do
+ on(DoesNotExistPage).create_source
end
When(/^I click Save page button$/) do
on(EditPage).save
@@ -16,7 +16,7 @@
on(ArticlePage).discussion_element.should exist
end
Then(/^link Create should be there$/) do
- on(DoesNotExistPage).create_element.should exist
+ on(DoesNotExistPage).create_source_element.should exist
end
Then(/^newly created page should open$/) do
@browser.url.should match Regexp.escape(@does_not_exist_page_name)
@@ -46,7 +46,7 @@
end
Given(/^I create the page to be moved$/) do
- step 'I click link Create'
+ step 'I click link Create source'
step 'I enter article text'
step 'I click Save page button'
end
@@ -86,7 +86,7 @@
end
Given(/^I have clicked Move on the newly created page$/) do
- step 'I click link Create'
+ step 'I click link Create source'
step 'I enter article text'
step 'I click Save page button'
step 'I click Move'
@@ -120,7 +120,7 @@
end
end
-Then(/^the old page should display a redirect to the new page$/) do
+Then(/^the old page should display a redirect to the new page$/) do
on(MovePage) do |page|
page.moved_page_link_element(@does_not_exist_page_name).when_present.click
page.body_content.should match(/Moved/)
diff --git a/features/support/pages/does_not_exist_page.rb
b/features/support/pages/does_not_exist_page.rb
index 6167eb3..299c772 100644
--- a/features/support/pages/does_not_exist_page.rb
+++ b/features/support/pages/does_not_exist_page.rb
@@ -4,6 +4,6 @@
include URL
page_url URL.url('<%=params[:page_name]%>')
- a(:create, text: 'Create source')
+ a(:create_source, text: 'Create source')
div(:page_text, id: 'mw-content-text')
end
--
To view, visit https://gerrit.wikimedia.org/r/70044
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d75ce18a692af706e2a21a8015948898d14d71f
Gerrit-PatchSet: 3
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Karima Rafes <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: Karima Rafes <[email protected]>
Gerrit-Reviewer: Rachel99 <[email protected]>
Gerrit-Reviewer: Zfilipin <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
