jenkins-bot has submitted this change and it was merged.
Change subject: Regression: fix a JS error on upload with a nag
......................................................................
Regression: fix a JS error on upload with a nag
NagOverlay wasn't calling its parent constructor.
Change-Id: I2bca90676185d690e4081b7648fd4dc8d00baa3f
---
M javascripts/common/uploads/NagOverlay.js
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/common/uploads/NagOverlay.js
b/javascripts/common/uploads/NagOverlay.js
index e63ab89..da896dc 100644
--- a/javascripts/common/uploads/NagOverlay.js
+++ b/javascripts/common/uploads/NagOverlay.js
@@ -10,7 +10,7 @@
template: M.template.get( 'photoNag' ),
- initialize: function() {
+ initialize: function( options ) {
this.learnMoreOverlay = new LearnMoreOverlay( {
parent: this,
heading: mw.msg(
'mobile-frontend-photo-nag-learn-more-heading' ),
@@ -20,6 +20,8 @@
mw.msg(
'mobile-frontend-photo-nag-learn-more-3' )
]
} );
+
+ this._super( options );
},
postRender: function( options ) {
--
To view, visit https://gerrit.wikimedia.org/r/71656
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2bca90676185d690e4081b7648fd4dc8d00baa3f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
