jenkins-bot has submitted this change and it was merged.
Change subject: Emit select null on selected item removal
......................................................................
Emit select null on selected item removal
Issues:
* Selected item is removed, but no select even was emitted
Changes:
ve.ui.SelectWidget.js
* On remove, emit select null when removing a selected item
* On clear, emit select null always
Change-Id: I1a94b0f8a841611b20e09f6c02f37fb9589e85c3
---
M modules/ve/ui/widgets/ve.ui.SelectWidget.js
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Robmoen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/ui/widgets/ve.ui.SelectWidget.js
b/modules/ve/ui/widgets/ve.ui.SelectWidget.js
index 38c8549..5dc76f3 100644
--- a/modules/ve/ui/widgets/ve.ui.SelectWidget.js
+++ b/modules/ve/ui/widgets/ve.ui.SelectWidget.js
@@ -377,6 +377,9 @@
// Remove existing item
delete this.hashes[hash];
}
+ if ( item.isSelected() ) {
+ this.selectItem( null );
+ }
}
ve.ui.GroupElement.prototype.removeItems.call( this, items );
@@ -399,6 +402,7 @@
// Clear all items
this.hashes = {};
ve.ui.GroupElement.prototype.clearItems.call( this );
+ this.selectItem( null );
this.emit( 'remove', items );
--
To view, visit https://gerrit.wikimedia.org/r/71561
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a94b0f8a841611b20e09f6c02f37fb9589e85c3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Robmoen <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
