jenkins-bot has submitted this change and it was merged.
Change subject: Title diff links should not include any fragment
......................................................................
Title diff links should not include any fragment
Change-Id: I54d602ad910035033c3ff2741616fd0405c6e290
---
M formatters/BasicFormatter.php
M formatters/EditFormatter.php
2 files changed, 7 insertions(+), 1 deletion(-)
Approvals:
EBernhardson (WMF): Looks good to me, approved
jenkins-bot: Verified
diff --git a/formatters/BasicFormatter.php b/formatters/BasicFormatter.php
index 7354e38..800d8c0 100644
--- a/formatters/BasicFormatter.php
+++ b/formatters/BasicFormatter.php
@@ -616,6 +616,10 @@
$eventData = $event->getExtra();
if ( isset( $eventData['revid'] ) &&
$event->getTitle() ) {
$target = $event->getTitle();
+ // Explicitly set fragment to empty
string for diff links, $title is
+ // passed around by reference, it may
end up using fragment set from
+ // other parameters
+ $target->setFragment( '#' );
$query = array(
'oldid' => $eventData['revid'],
'diff' => 'prev',
diff --git a/formatters/EditFormatter.php b/formatters/EditFormatter.php
index 31dda39..3577f8f 100644
--- a/formatters/EditFormatter.php
+++ b/formatters/EditFormatter.php
@@ -23,7 +23,9 @@
'param' => array(
'oldid' => $revid,
'diff' => 'prev',
- )
+ ),
+ // Set fragment to empty string for diff links
+ 'fragment' => ''
);
$this->setTitleLink( $event, $message, $props );
} elseif ( $param === 'summary' ) {
--
To view, visit https://gerrit.wikimedia.org/r/71723
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I54d602ad910035033c3ff2741616fd0405c6e290
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Bsitu <[email protected]>
Gerrit-Reviewer: EBernhardson (WMF) <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
