EBernhardson (WMF) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/71740


Change subject: Make wfForeignMemcKey consistent with wfMemcKey
......................................................................

Make wfForeignMemcKey consistent with wfMemcKey

The wfMemcKey function converts any spaces in the key into _,
the wfForeignMemcKey does not.  As such they would not return the same
key in certain corner cases.

Change-Id: I520dacdce953414dee5907324c2c98db858bcd42
---
M includes/GlobalFunctions.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/40/71740/1

diff --git a/includes/GlobalFunctions.php b/includes/GlobalFunctions.php
index a44e45b..30b36e3 100644
--- a/includes/GlobalFunctions.php
+++ b/includes/GlobalFunctions.php
@@ -3384,7 +3384,7 @@
        } else {
                $key = $db . ':' . implode( ':', $args );
        }
-       return $key;
+       return str_replace( ' ', '_', $key );
 }
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/71740
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I520dacdce953414dee5907324c2c98db858bcd42
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: EBernhardson (WMF) <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to