jenkins-bot has submitted this change and it was merged.
Change subject: postEdit needs to run before GS logging
......................................................................
postEdit needs to run before GS logging
The ext.gettingstarted.logging module didn't depend on postEdit as
taskToolbar does; I think that's why openTask sometimes logs
page-impression instead of page-save-success.
Bug: 50204
Change-Id: I55b6a70d9318fef104e383e7aba6931bbfbf840b
---
M GettingStarted.php
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Mattflaschen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/GettingStarted.php b/GettingStarted.php
index 8f5bef6..7a86c26 100644
--- a/GettingStarted.php
+++ b/GettingStarted.php
@@ -152,6 +152,7 @@
$wgResourceModules[ 'ext.gettingstarted.logging' ] = array(
'scripts' => 'ext.gettingstarted.logging.js',
'dependencies' => array(
+ 'mediawiki.action.view.postEdit',
'jquery.cookie',
'jquery.json',
'mediawiki.Title',
--
To view, visit https://gerrit.wikimedia.org/r/71575
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I55b6a70d9318fef104e383e7aba6931bbfbf840b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: master
Gerrit-Owner: Spage <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: Swalling <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
