ArielGlenn has submitted this change and it was merged.

Change subject: Set max commit summary lengths for Gerrit
......................................................................


Set max commit summary lengths for Gerrit

This doesn't block them from being submitted, but will provide
feedback to the user when they've got a super long line. The
defaults are too narrow and will annoy more people than they
help, but we can at least let people know when their commit
message is really long.

Change-Id: I2df7f2c911788d01a8873f89e1cd4890f7d7f125
---
M templates/gerrit/gerrit.config.erb
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  ArielGlenn: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/templates/gerrit/gerrit.config.erb 
b/templates/gerrit/gerrit.config.erb
index 365e4be..3df88d2 100644
--- a/templates/gerrit/gerrit.config.erb
+++ b/templates/gerrit/gerrit.config.erb
@@ -124,3 +124,6 @@
        commentOnCommentAdded = false
        commentOnPatchSetCreated = false
        commentOnRefUpdatedGitWeb = false
+[commitmessage]
+       maxSubjectLength = 100
+       maxLineLength = 120

-- 
To view, visit https://gerrit.wikimedia.org/r/66665
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2df7f2c911788d01a8873f89e1cd4890f7d7f125
Gerrit-PatchSet: 4
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Demon <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: ArielGlenn <[email protected]>
Gerrit-Reviewer: Demon <[email protected]>
Gerrit-Reviewer: Ryan Lane <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to