Aude has submitted this change and it was merged.
Change subject: Revert "Introduce the propagateChangesToRepo client setting"
......................................................................
Revert "Introduce the propagateChangesToRepo client setting"
This reverts commit 5a6511760562dc5b8fae033492af704599141640
Without Iad9bd7065bb0874ebf52e65a8558fc8f091bdeec this is not
only useless but will fatal out!
Change-Id: I1b1508c39c93072c1516bc32d518b9c01082b11d
---
M client/WikibaseClient.hooks.php
M client/config/WikibaseClient.default.php
M docs/options.wiki
3 files changed, 0 insertions(+), 64 deletions(-)
Approvals:
Aude: Verified; Looks good to me, approved
diff --git a/client/WikibaseClient.hooks.php b/client/WikibaseClient.hooks.php
index 7010891..34e8b46 100644
--- a/client/WikibaseClient.hooks.php
+++ b/client/WikibaseClient.hooks.php
@@ -725,66 +725,4 @@
}
return true;
}
-
- /**
- * After a page has been moved also update the item on the repo
- * This only works with CentralAuth
- *
- * @see https://www.mediawiki.org/wiki/Manual:Hooks/TitleMoveComplete
- *
- * @param Title $oldTitle
- * @param Title $newTitle
- * @param User $user
- * @param integer $pageid database ID of the page that's been moved
- * @param integer $redirid database ID of the created redirect
- *
- * @return bool
- */
- public static function onTitleMoveComplete( $oldTitle, $newTitle,
$user, $pageId, $redirectId ) {
- wfProfileIn( __METHOD__ );
-
- if ( Settings::get( 'propagateChangesToRepo' ) !== true ) {
- wfProfileOut( __METHOD__ );
- return true;
- }
-
- $repoDB = Settings::get( 'repoDatabase' );
- $siteLinkLookup =
WikibaseClient::getDefaultInstance()->getStore()->getSiteLinkTable();
- $jobQueueGroup = \JobQueueGroup::singleton( $repoDB );
-
- if ( !$jobQueueGroup ) {
- wfLogWarning( "Failed to acquire a JobQueueGroup for
$repoDB" );
- wfProfileOut( __METHOD__ );
- return true;
- }
-
- $updateRepo = new UpdateRepoOnMove(
- $repoDB,
- $siteLinkLookup,
- $user,
- Settings::get( 'siteGlobalID' ),
- $oldTitle,
- $newTitle
- );
-
- if ( !$updateRepo || !$updateRepo->getEntityId() ||
!$updateRepo->userIsValidOnRepo() ) {
- wfProfileOut( __METHOD__ );
- return true;
- }
-
- try {
- $updateRepo->injectJob( $jobQueueGroup );
-
- // To be able to find out about this in the
SpecialMovepageAfterMove hook
- $newTitle->wikibasePushedMoveToRepo = true;
- } catch( \RuntimeException $e ) {
- // This is not a reason to let an exception bubble up,
we just
- // show a message to the user that the Wikibase item
needs to be
- // manually updated.
- wfLogWarning( $e->getMessage() );
- }
-
- wfProfileOut( __METHOD__ );
- return true;
- }
}
diff --git a/client/config/WikibaseClient.default.php
b/client/config/WikibaseClient.default.php
index 23a7946..a141f0d 100644
--- a/client/config/WikibaseClient.default.php
+++ b/client/config/WikibaseClient.default.php
@@ -57,7 +57,6 @@
),
'allowDataTransclusion' => true,
'enableSiteLinkWidget' => false,
- 'propagateChangesToRepo' => true,
'siteGroup' => 'wikipedia', //TODO: require this to be set,
default doesn't make sense.
diff --git a/docs/options.wiki b/docs/options.wiki
index a707795..d9649bb 100644
--- a/docs/options.wiki
+++ b/docs/options.wiki
@@ -85,7 +85,6 @@
</poem>
;allowDataTransclusion: switch to enable data transclusion features like the
<nowiki>{{#property}}</nowiki> parser function and the <tt>wikibase</tt>
Scribunto module. Defaults to <tt>true</tt>.
;enableSiteLinkWidget: switch to enable or disable add site link widget.
Defaults to <tt>false</tt>.
-;propagateChangesToRepo: switch to enable or disable the propagation of client
changes to the repo. Defaults to <tt>true</tt>.
=== Expert Settings ===
;injectRecentChanges: whether changes on the repository should be injected
into this wiki's recent changes table, so they show up on watchlists, etc.
Requires the <code>dispatchChanges.php</code> script to run, and this wiki to
be listed in the <code>localClientDatabases</code> setting on the repository.
--
To view, visit https://gerrit.wikimedia.org/r/71815
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b1508c39c93072c1516bc32d518b9c01082b11d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: mw1.22-wmf9
Gerrit-Owner: Hoo man <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
