jenkins-bot has submitted this change and it was merged.
Change subject: Fix focusable highlights
......................................................................
Fix focusable highlights
!$element.is( ':visible' ) - jQuery .is() returns boolean based on the
parameter.
$element.not( ':visible' ) - jQuery .not() returns a filtered jQuery
collection with elements matching the parameter removed.
Change-Id: Iedf55f3453514ee710bbb6d702bbf9a5570a4a1d
---
M modules/ve/ce/ve.ce.FocusableNode.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Trevor Parscal: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/ce/ve.ce.FocusableNode.js
b/modules/ve/ce/ve.ce.FocusableNode.js
index 328c672..6647d3e 100644
--- a/modules/ve/ce/ve.ce.FocusableNode.js
+++ b/modules/ve/ce/ve.ce.FocusableNode.js
@@ -152,7 +152,7 @@
this.$.find( '*' ).add( this.$ ).each(
ve.bind( function( i, element ) {
var offset, $element = $( element );
- if ( $element.not( ':visible' ) ) {
+ if ( !$element.is( ':visible' ) ) {
return true;
}
offset = ve.Element.getRelativePosition(
--
To view, visit https://gerrit.wikimedia.org/r/71922
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iedf55f3453514ee710bbb6d702bbf9a5570a4a1d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Christian <[email protected]>
Gerrit-Reviewer: Robmoen <[email protected]>
Gerrit-Reviewer: Trevor Parscal <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
