jenkins-bot has submitted this change and it was merged.
Change subject: Revert "Address error caused by changing focus from context
menu to window."
......................................................................
Revert "Address error caused by changing focus from context menu to window."
Just a proof-of-concept that this would work on Opera. I'm figuring out
what was this for initially...
This reverts commit 30dadb6c8c1b684fecfc066b003c92e78ae66124.
Bug: 47794
Change-Id: Ie4f1334e0beb7ba7d4f4aa3b42464fa219c4778c
---
M modules/ve/ui/ve.ui.Context.js
1 file changed, 2 insertions(+), 11 deletions(-)
Approvals:
Trevor Parscal: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/ui/ve.ui.Context.js b/modules/ve/ui/ve.ui.Context.js
index 09b4273..37fc98b 100644
--- a/modules/ve/ui/ve.ui.Context.js
+++ b/modules/ve/ui/ve.ui.Context.js
@@ -54,9 +54,9 @@
'open': 'onInspectorOpen',
'close': 'onInspectorClose'
} );
+
this.$$( this.getElementWindow() ).on( {
- 'resize': ve.bind( this.update, this ),
- 'focus': ve.bind( this.onWindowFocus, this )
+ 'resize': ve.bind( this.update, this )
} );
this.$.add( this.$menu )
.on( 'mousedown', false );
@@ -123,15 +123,6 @@
ve.ui.Context.prototype.onRelocationEnd = function () {
this.relocating = false;
this.update();
-};
-
-/**
- * Handle window focus events on the view.
- *
- * @method
- */
-ve.ui.Context.prototype.onWindowFocus = function () {
- this.hide();
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/61365
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4f1334e0beb7ba7d4f4aa3b42464fa219c4778c
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Matmarex <[email protected]>
Gerrit-Reviewer: Matmarex <[email protected]>
Gerrit-Reviewer: Robmoen <[email protected]>
Gerrit-Reviewer: Trevor Parscal <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
