jenkins-bot has submitted this change and it was merged.
Change subject: Regression: fix background glitch in left nav
......................................................................
Regression: fix background glitch in left nav
Introduced in f532ca60e85530456aea9a9c5ddd4d363816a5f1
Without this, when the screen height was greater than left nav's height,
grey background would extend below article's content.
Change-Id: I3b28e823698de078dbf480f11b427976ccc1b446
---
M less/common/mainmenu.less
M stylesheets/common/ui.css
2 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/less/common/mainmenu.less b/less/common/mainmenu.less
index 9f831f3..d2c023b 100644
--- a/less/common/mainmenu.less
+++ b/less/common/mainmenu.less
@@ -118,6 +118,9 @@
margin-left: -@menuBorder;
// disable horizontal scrolling
overflow: hidden;
+ // the two following properties are needed to override the
height set
+ // by position: fixed fallback on scroll event
+ min-height: 100%;
height: auto !important;
}
diff --git a/stylesheets/common/ui.css b/stylesheets/common/ui.css
index 2df0653..0cfe9d7 100644
--- a/stylesheets/common/ui.css
+++ b/stylesheets/common/ui.css
@@ -305,6 +305,7 @@
body.navigation-enabled #mw-mf-viewport {
margin-left: -12px;
overflow: hidden;
+ min-height: 100%;
height: auto !important;
}
body.navigation-enabled #mw-mf-page-center {
--
To view, visit https://gerrit.wikimedia.org/r/71935
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b28e823698de078dbf480f11b427976ccc1b446
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
