Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/72118
Change subject: Blacklist Firefox 11 and 12
......................................................................
Blacklist Firefox 11 and 12
Bug: 50780
Change-Id: I38b1e3bbc7153c0fa14fc8a3d7dc10f221f3ea23
---
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
M modules/ve-mw/test/init/targets/ve.init.mw.ViewPageTarget.test.js
3 files changed, 14 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/18/72118/1
diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
index 72512df..0be5260 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
@@ -85,8 +85,8 @@
'msie': [['<=', 10]],
// Android 2.x and below "support" CE but don't trigger
keyboard input
'android': [['<', 3]],
- // Bug 50534 - apparently Firefox is broken in versions
10 and below
- 'firefox': [['<=', 10]],
+ // Bug 50780 - apparently Firefox is broken in versions
12 and below
+ 'firefox': [['<=', 12]],
// Blacklist all versions:
'opera': null,
'blackberry': null
diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
index 7548800..b28560e 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
@@ -157,7 +157,7 @@
// The value is either null (match all versions) or a list of tuples
// containing an inequality (<,>,<=,>=) and a version number
'whitelist': {
- 'firefox': [['>=', 11]],
+ 'firefox': [['>=', 13]],
'iceweasel': [['>=', 10]],
'safari': [['>=', 5]],
'chrome': [['>=', 19]]
diff --git a/modules/ve-mw/test/init/targets/ve.init.mw.ViewPageTarget.test.js
b/modules/ve-mw/test/init/targets/ve.init.mw.ViewPageTarget.test.js
index 45378f0..d58772d 100644
--- a/modules/ve-mw/test/init/targets/ve.init.mw.ViewPageTarget.test.js
+++ b/modules/ve-mw/test/init/targets/ve.init.mw.ViewPageTarget.test.js
@@ -43,7 +43,17 @@
},
{
'msg': 'Firefox 11',
- 'userAgent': 'Mozilla/5.0 (X11; U; Linux i686;
en-US; rv:1.9.1.16) Gecko/20120421 Gecko Firefox/11.0',
+ 'userAgent': 'Mozilla/5.0 (Windows NT 6.1;
U;WOW64; de;rv:11.0) Gecko Firefox/11.0',
+ 'matches': [ 'blacklist' ]
+ },
+ {
+ 'msg': 'Firefox 12',
+ 'userAgent': 'Mozilla/5.0 (compatible; Windows;
U; Windows NT 6.2; WOW64; en-US; rv:12.0) Gecko/20120403211507 Firefox/12.0',
+ 'matches': [ 'blacklist' ]
+ },
+ {
+ 'msg': 'Firefox 13',
+ 'userAgent': 'Mozilla/5.0 (X11; Ubuntu; Linux
x86_64; rv:13.0) Gecko/20100101 Firefox/13.0',
'matches': [ 'whitelist' ]
},
{
--
To view, visit https://gerrit.wikimedia.org/r/72118
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I38b1e3bbc7153c0fa14fc8a3d7dc10f221f3ea23
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
