QChris has uploaded a new change for review.
https://gerrit.wikimedia.org/r/72149
Change subject: Prohibit uploading draft patch sets to non-draft changes
......................................................................
Prohibit uploading draft patch sets to non-draft changes
It was possible to upload draft patch sets to non-draft changes. This
is confusing for users, because for users who can submit but lack
permission to see the draft patch set, the submit button is gone and
they do not why. The only hint is the “Submit Type” in the top-left
corner says ERROR.
To avoid this confusion, we prohibit uploading drafts to non-draft
changes.
Bug: 50838
Change-Id: Ic6aa76b8110e424984ca3ec5edc2e1c0c494e029
---
M gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/gerrit refs/changes/49/72149/1
diff --git
a/gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java
b/gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java
index 46cef50..a685abd 100644
---
a/gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java
+++
b/gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java
@@ -1298,6 +1298,13 @@
return false;
}
+ if (magicBranch.isDraft()
+ && change.getStatus().getCode() != Change.STATUS_DRAFT) {
+ reject(cmd, "Cannot upload draft patch set to non-draft change "
+ + change.getChangeId());
+ return false;
+ }
+
final ReplaceRequest req =
new ReplaceRequest(change.getId(), newCommit, cmd, checkMergedInto);
if (replaceByChange.containsKey(req.ontoChange)) {
--
To view, visit https://gerrit.wikimedia.org/r/72149
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic6aa76b8110e424984ca3ec5edc2e1c0c494e029
Gerrit-PatchSet: 1
Gerrit-Project: gerrit
Gerrit-Branch: wmf
Gerrit-Owner: QChris <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
